devroom.io/content/posts/2008-08-17-skinny-controllers-and-overweight-models.md
2013-03-24 22:28:43 +01:00

60 lines
1.8 KiB
Markdown

---
title: "Skinny Controllers and Overweight Models"
kind: article
slug: skinny-controllers-and-overweight-models
created_at: 2008-08-17
tags:
- Blog
- Ruby
- Rails
- controllers
- models
---
All Rails developers know the slogan "Skinny Controllers, Fat Models" and I heartily agree with it. Every conference you go to, you hear it. But there's a problem! My Fat models got overweight!
What happened? By stuffing all applications logic in the Models, they become fat, very fat. Although this is supposed to be a good thing, I don't like it. My models get so fat that it takes me forever to scroll through it and find the method I'm working on. There must be a better way!
Well, yes there is: create modules! Normally you'd write a module to reuse your code in different places, but there's no rule that says you may not use a module only once.
So, I package all related code (e.g. Authentication, state management, managing associated objects, etc) into different modules and place them in the /lib directory. Let's say you have a a bunch of methods to handle keep a counter on your User model
:::ruby
Class User < ActiveRecord::Base
attr_accessor :counter
def up
counter += 1
end
def down
counter -= 1
end
def reset
counter = 0
end
end
You could create a new file lib/counter.rb and include that module in your User model.
:::ruby
Class User < ActiveRecord::Base
attr_accessor :counter
include Counter
end
module Counter
def up
counter += 1
end
def down
counter -= 1
end
def reset
counter = 0
end
end
As you can see, this keeps your fat User model clean and makes it easier for you to find code that applies to a certain function.